[codex] fix desktop context menu zoom positioning by juliusmarminge · Pull Request #2620 · pingdotgg/t3code

juliusmarminge · 2026-05-09T17:09:58Z

What changed

Scale desktop context menu coordinates by the renderer zoom factor before sending them to Electron's native Menu.popup API.
Make the macOS destructive trash icon explicit theme-aware by generating separate light/dark native image variants and keeping template-image mode enabled.
Publish Electron zoom into CSS variables so macOS titlebar chrome spacing stays aligned with the native traffic lights under zoom.
Tune titlebar X spacing in screen space: zoom-in keeps full native clearance, while zoom-out gradually reduces apparent left spacing with an 82px traffic-light-safe floor. Y/titlebar-height compensation remains unchanged.
Hide the Electron sidebar wordmark only when the measured rendered wordmark no longer fits between the traffic-light clearance and the sidebar rail.
Removed the polling-based titlebar zoom sync; the renderer now updates from load, resize/visualViewport resize, and the Electron zoom message path with requestAnimationFrame coalescing.
Added focused tests for context menu zoom math, theme-matched menu icons, and titlebar zoom CSS variable math.

Why

React mouse events report positions in the web page's zoomed CSS pixel coordinate space, while Electron's native menu popup positioning expects unzoomed window coordinates. When the user zoomed the desktop app out, right-click context menus opened offset from the pointer.

The trash icon also came from a black named native image and did not reliably tint against dark native menus, so the icon now uses Electron's active native theme when the menu template is built.

The sidebar logo/header used a fixed CSS pixel offset to clear the macOS traffic-light buttons. Electron zoom scales that web offset, but the native titlebar buttons do not move. The horizontal titlebar spacing now follows a gentler zoom-out curve so small zoom levels reduce excessive spacing without letting the logo enter the traffic-light area. At very small zoom levels, the wordmark now hides only once its measured rendered width no longer fits in the remaining header slot.

Validation

bun fmt
bun lint (passed with existing unrelated warnings)
bun typecheck
bun run test --filter=@t3tools/desktop -- desktopZoom contextMenuPosition ElectronMenu DesktopWindow

Note

Fix desktop context menu zoom positioning and titlebar CSS variable sync

Adds scaleContextMenuPositionForElectron in contextMenuPosition.ts to multiply context menu coordinates by the current webFrame zoom factor before sending them via IPC, fixing misaligned menus at non-default zoom levels.
Adds resolveDesktopZoomCssVariables in desktopZoom.ts to compute zoom-compensated --desktop-titlebar-height and --desktop-titlebar-leading-offset CSS variables.
The preload writes these CSS variables on startup, on window/visualViewport resize, and when the main process sends desktop:zoom-factor-changed over a new IPC channel.
DesktopWindow.ts emits desktop:zoom-factor-changed with the current zoom factor on zoom-changed and did-finish-load events.
In Electron, the sidebar wordmark is hidden via a ResizeObserver/resize listener when the header has insufficient horizontal space.

^{Macroscope summarized 412962e.}

Note

Low Risk
Desktop UI/preload IPC changes with focused unit tests; no auth, data, or security-sensitive paths.

Overview
Fixes misaligned native context menus when the desktop app is zoomed by scaling popup coordinates from CSS pixels to what Electron expects before IPC (scaleContextMenuPositionForElectron in preload).

Adds zoom-aware macOS sidebar titlebar layout: the main process pushes the current zoom factor via desktop:zoom-factor-changed; preload sets --desktop-zoom-factor, --desktop-titlebar-height, and --desktop-titlebar-leading-offset (with a gentler zoom-out curve and a traffic-light-safe minimum leading offset). The Electron sidebar header uses those variables instead of fixed 52px / 90px padding.

The sidebar wordmark hides (keeps layout space) when measured width no longer fits the header after padding, using ResizeObserver and viewport resize coalescing.

Unit tests cover context-menu scaling and titlebar CSS math.

^{Reviewed by Cursor Bugbot for commit 412962e. Bugbot is set up for automated code reviews on this repo. Configure here.}

coderabbitai · 2026-05-09T17:10:05Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 569d1ff4-2bc1-4b49-b750-c0511512c501

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch t3code/195ddd89

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

macroscopeapp · 2026-05-09T17:30:26Z

Approvability

Verdict: Approved

Targeted bug fix for desktop context menu positioning when zoomed. Adds well-tested utility functions for scaling coordinates/CSS variables by zoom factor, with straightforward mathematical logic and no broader behavioral changes.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate c06f7ed

Dismissing prior approval to re-evaluate 412962e

github-actions · 2026-06-16T18:20:55Z

🚀 Expo continuous deployment is ready!

Project → t3-code
Platforms → android, ios
Scheme → t3code-preview

	🤖 Android	🍎 iOS
Fingerprint	971e873f513ad97675807fa4bf5eb9577ad935ce	3d9696e1c58021a1749a75e2a781a9012f956663
Build Details	Build Permalink Details Distribution: `INTERNAL` Build profile: `preview:dev` Runtime version: `971e873f513ad97675807fa4bf5eb9577ad935ce` App version: `0.1.0` Git commit: `df68d2e210b3d459b5c02ccee9424163cd643dd6`	Build Permalink Details Distribution: `INTERNAL` Build profile: `preview:dev` Runtime version: `3d9696e1c58021a1749a75e2a781a9012f956663` App version: `0.1.0` Git commit: `df68d2e210b3d459b5c02ccee9424163cd643dd6`
Update Details	Update Permalink Details Branch: `pr-2620` Runtime version: `971e873f513ad97675807fa4bf5eb9577ad935ce` Git commit: `df68d2e210b3d459b5c02ccee9424163cd643dd6`	Update Permalink Details Branch: `pr-2620` Runtime version: `3d9696e1c58021a1749a75e2a781a9012f956663` Git commit: `df68d2e210b3d459b5c02ccee9424163cd643dd6`
Update QR

github-actions Bot added size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels May 9, 2026

juliusmarminge marked this pull request as ready for review May 9, 2026 17:22

juliusmarminge force-pushed the t3code/195ddd89 branch from 76d2a21 to f2ae3bc Compare May 9, 2026 17:24

juliusmarminge marked this pull request as draft May 9, 2026 17:25

github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels May 9, 2026

macroscopeapp Bot previously approved these changes May 9, 2026

View reviewed changes

juliusmarminge force-pushed the t3code/195ddd89 branch from f2ae3bc to 7a7811f Compare May 9, 2026 17:31

github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels May 9, 2026

juliusmarminge force-pushed the t3code/195ddd89 branch 4 times, most recently from 0b6fbb3 to c06f7ed Compare May 9, 2026 17:51

juliusmarminge marked this pull request as ready for review May 9, 2026 17:56

macroscopeapp Bot previously approved these changes May 9, 2026

View reviewed changes

juliusmarminge mentioned this pull request Jun 1, 2026

[Bug]: RIght-click behaviour on projects and threads is inconsistent. #2535

Closed

2 tasks

juliusmarminge mentioned this pull request Jun 10, 2026

Fix desktop context menu rendering #280

Closed

fix desktop context menu zoom positioning

412962e

juliusmarminge force-pushed the t3code/195ddd89 branch from c06f7ed to 412962e Compare June 16, 2026 18:18

macroscopeapp Bot approved these changes Jun 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[codex] fix desktop context menu zoom positioning#2620

[codex] fix desktop context menu zoom positioning#2620
juliusmarminge wants to merge 1 commit into
mainfrom
t3code/195ddd89

juliusmarminge commented May 9, 2026 •

edited by macroscopeapp Bot

Loading

Uh oh!

coderabbitai Bot commented May 9, 2026 •

edited

Loading

Review skipped

Uh oh!

macroscopeapp Bot commented May 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

juliusmarminge commented May 9, 2026 • edited by macroscopeapp Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Why

Validation

Fix desktop context menu zoom positioning and titlebar CSS variable sync

Uh oh!

coderabbitai Bot commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

macroscopeapp Bot commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

juliusmarminge commented May 9, 2026 •

edited by macroscopeapp Bot

Loading

coderabbitai Bot commented May 9, 2026 •

edited

Loading

macroscopeapp Bot commented May 9, 2026 •

edited

Loading